• OGAWA Hirofumi's avatar
    [PATCH] arch/i386/pci/mmconfig.c tlb flush fix · 8d1c4819
    OGAWA Hirofumi authored
    We use the fixmap for accessing pci config space in pci_mmcfg_read/write().
    The problem is in pci_exp_set_dev_base(). It is caching a last
    accessed address to avoid calling set_fixmap_nocache() whenever
    pci_mmcfg_read/write() is used.
    
      static inline void pci_exp_set_dev_base(int bus, int devfn)
      {
    	u32 dev_base = base | (bus << 20) | (devfn << 12);
    	if (dev_base != mmcfg_last_accessed_device) {
    		mmcfg_last_accessed_device = dev_base;
    		set_fixmap_nocache(FIX_PCIE_MCFG, dev_base);
    	}
      }
    
                cpu0                                        cpu1
      ---------------------------------------------------------------------------
        pci_mmcfg_read("device-A")
            pci_exp_set_dev_base()
                set_fixmap_nocache()
                                                  pci_mmcfg_read("device-B")
                                                      pci_exp_set_dev_base()
                                                          set_fixmap_nocache()
        pci_mmcfg_read("device-B")
            pci_exp_set_dev_base()
                /* doesn't flush tlb */
    
    But if cpus accessed the above order, the second pci_mmcfg_read() on
    cpu0 doesn't flush the TLB, because "mmcfg_last_accessed_device" is
    device-B.  So, second pci_mmcfg_read() on cpu0 accesses a device-A via
    a previous TLB cache. This problem became the cause of several strange
    behavior.
    
    This patches fixes this situation by adds "mmcfg_last_accessed_cpu" check.
    
    [ Alternatively, we could make a per-cpu mapping area or something. Not
      that it's probably worth it, but if we wanted to avoid all locking and
      instead just disable preemption, that would be the way to go. --Linus ]
    Signed-off-by: default avatarOGAWA Hirofumi <hogawa@miraclelinux.com>
    Signed-off-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    8d1c4819
mmconfig.c 5.55 KB