• Paul Mackerras's avatar
    x86: atomic64: Code atomic(64)_read and atomic(64)_set in C not CPP · 8e049ef0
    Paul Mackerras authored
    Occasionally we get bugs where atomic_read or atomic_set are
    used on atomic64_t variables or vice versa.  These bugs don't
    generate warnings on x86 because atomic_read and atomic_set are
    coded as macros rather than C functions, so we don't get any
    type-checking on their arguments; similarly for atomic64_read
    and atomic64_set in 64-bit kernels.
    
    This converts them to C functions so that the arguments are
    type-checked and bugs like this will get caught more easily. It
    also converts atomic_cmpxchg and atomic_xchg, and
    atomic64_cmpxchg and atomic64_xchg on 64-bit, so we get
    type-checking on their arguments too.
    
    Compiling a typical 64-bit x86 config, this generates no new
    warnings, and the vmlinux text is 86 bytes smaller.
    
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: David Howells <dhowells@redhat.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Arnd Bergmann <arnd@arndb.de>
    LKML-Reference: <alpine.LFD.2.01.0907021653030.3210@localhost.localdomain>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    8e049ef0
atomic_64.h 10.9 KB