• Gerrit Renker's avatar
    [DCCP]: Honour and make use of shutdown option set by user · 8e8c71f1
    Gerrit Renker authored
    This extends the DCCP socket API by honouring any shutdown(2) option set by the user.
    The behaviour is, as much as possible, made consistent with the API for TCP's shutdown.
    
    This patch exploits the information provided by the user via the socket API to reduce
    processing costs:
     * if the read end is closed (SHUT_RD), it is not necessary to deliver to input CCID;
     * if the write end is closed (SHUT_WR), the same idea applies, but with a difference -
       as long as the TX queue has not been drained, we need to receive feedback to keep
       congestion-control rates up to date. Hence SHUT_WR is honoured only after the last
       packet (under congestion control) has been sent;
     * although SHUT_RDWR seems nonsensical, it is nevertheless supported in the same manner
       as for TCP (and agrees with test for SHUTDOWN_MASK in dccp_poll() in net/dccp/proto.c).
    
    Furthermore, most of the code already honours the sk_shutdown flags (dccp_recvmsg() for
    instance sets the read length to 0 if SHUT_RD had been called); CCID handling is now added
    to this by the present patch.
    
    There will also no longer be any delivery when the socket is in the final stages, i.e. when
    one of dccp_close(), dccp_fin(), or dccp_done() has been called - which is fine since at
    that stage the connection is its final stages.
    
    Motivation and background are on http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/shutdown
    
    A FIXME has been added to notify the other end if SHUT_RD has been set (RFC 4340, 11.7).
    
    Note: There is a comment in inet_shutdown() in net/ipv4/af_inet.c which asks to "make
          sure the socket is a TCP socket". This should probably be extended to mean
          `TCP or DCCP socket' (the code is also used by UDP and raw sockets).
    Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
    Signed-off-by: default avatarIan McDonald <ian.mcdonald@jandi.co.nz>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    8e8c71f1
proto.c 27 KB