• Stephan Mueller's avatar
    crypto: drbg - fix memory corruption for AES192 · 8fecaad7
    Stephan Mueller authored
    For the CTR DRBG, the drbg_state->scratchpad temp buffer (i.e. the
    memory location immediately before the drbg_state->tfm variable
    is the buffer that the BCC function operates on. BCC operates
    blockwise. Making the temp buffer drbg_statelen(drbg) in size is
    sufficient when the DRBG state length is a multiple of the block
    size. For AES192 this is not the case and the length for temp is
    insufficient (yes, that also means for such ciphers, the final
    output of all BCC rounds are truncated before used to update the
    state of the DRBG!!).
    
    The patch enlarges the temp buffer from drbg_statelen to
    drbg_statelen + drbg_blocklen to have sufficient space.
    Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
    Signed-off-by: default avatarStephan Mueller <smueller@chronox.de>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    8fecaad7
drbg.c 56.7 KB