• Ard Biesheuvel's avatar
    efi/libstub/arm64: Set -fpie when building the EFI stub · 91ee5b21
    Ard Biesheuvel authored
    Clang may emit absolute symbol references when building in non-PIC mode,
    even when using the default 'small' code model, which is already mostly
    position independent to begin with, due to its use of adrp/add pairs
    that have a relative range of +/- 4 GB. The remedy is to pass the -fpie
    flag, which can be done safely now that the code has been updated to avoid
    GOT indirections (which may be emitted due to the compiler assuming that
    the PIC/PIE code may end up in a shared library that is subject to ELF
    symbol preemption)
    
    Passing -fpie when building code that needs to execute at an a priori
    unknown offset is arguably an improvement in any case, and given that
    the recent visibility changes allow the PIC build to pass with GCC as
    well, let's add -fpie for all arm64 builds rather than only for Clang.
    Tested-by: default avatarMatthias Kaehlcke <mka@chromium.org>
    Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Matt Fleming <matt@codeblueprint.co.uk>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-efi@vger.kernel.org
    Link: http://lkml.kernel.org/r/20170818194947.19347-5-ard.biesheuvel@linaro.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    91ee5b21
Makefile 3.75 KB