• Michael Auchter's avatar
    misc: eeprom: at24: fix regulator underflow · 58d6fee5
    Michael Auchter authored
    The at24 driver attempts to read a byte from the device to validate that
    it's actually present, and if not, disables the vcc regulator and
    returns -ENODEV. However, between the read and the error handling path,
    pm_runtime_idle() is called and invokes the driver's suspend callback,
    which also disables the vcc regulator. This leads to an underflow of the
    regulator enable count if the EEPROM is not present.
    
    Move the pm_runtime_suspend() call to be after the error handling path
    to resolve this.
    
    Fixes: cd5676db ("misc: eeprom: at24: support pm_runtime control")
    Signed-off-by: default avatarMichael Auchter <michael.auchter@ni.com>
    Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
    58d6fee5
at24.c 22.5 KB