• Alan Stern's avatar
    [PATCH] USB UHCI: fix broken data toggles for queued control URBs · 93cab357
    Alan Stern authored
    This patch fixes a long-standing (albeit unidentified) problem in the
    queueing code for the UHCI HCD.  The code propagates data toggle settings
    between messages in a queue for control transfers just the same as bulk
    and interrupt transfers.  That is a mistake, since control messages always
    restart with data toggle 0.  With this patch, the UHCI driver now passes
    test 10 (control URB queueing) in David Brownell's usbtest suite.
    
    The patch appears to change more than it really does, because it alters
    the indentation level of a large section of code.
    93cab357
uhci-hcd.c 64.5 KB