• Julia Lawall's avatar
    mfd: max8925-i2c: Drop unnecessary static · 09530751
    Julia Lawall authored
    Drop static on a local variable, when the variable is initialized before
    any use, on every possible execution path through the function.  The static
    has no benefit, and dropping it reduces the code size.
    
    The semantic patch that fixes this problem is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    // </smpl>
    
    The change in code size is indicates by the following output from the size
    command.
    
    before:
       text    data     bss     dec     hex filename
       2579     240      16    2835     b13 drivers/mfd/max8925-i2c.o
    
    after:
       text    data     bss     dec     hex filename
       2531     240       8    2779     adb drivers/mfd/max8925-i2c.o
    Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
    Acked-by: default avatarKees Cook <keescook@chromium.org>
    Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
    09530751
max8925-i2c.c 5.97 KB