• Federico Vaga's avatar
    ipoctal: protect only the real critical section · 968d04e8
    Federico Vaga authored
    In some conditions (echo or particular sequence of special
    characters), on buffer push, the tty layer calls the write operation
    while we are holding the spinlock. This means deadlock within the same
    process on kernels version < 3.12. It seems not a problem on recent
    kernel, but the patch still valid as locking optimization.
    
    The protected variables by the spinlock are: xmit_buf, nb_bytes,
    pointer_read and pointer_write. So, this patch reduces the locked area
    in the IRQ handler only to these variables. Most of the code inside the
    locked area in the IRQ handler is not protected elsewhere; it means
    that it is not protected at all.
    Signed-off-by: default avatarFederico Vaga <federico.vaga@cern.ch>
    Acked-by: default avatarSamuel Iglesias Gonsalvez <siglesias@igalia.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    968d04e8
ipoctal.c 18.6 KB