• Stefan Richter's avatar
    firewire: ohci: work around VIA and NEC PHY packet reception bug · a4dc090b
    Stefan Richter authored
    VIA VT6306, VIA VT6308, and NEC OrangeLink controllers do not write
    packet event codes for received PHY packets (or perhaps write
    evt_no_status, hard to tell).  Work around it by overwriting the
    packet's ACK by ack_complete, so that upper layers that listen to PHY
    packet reception get to see these packets.
    
    (Also tested:  TI TSB82AA2, TI TSB43AB22/A, TI XIO2213A, Agere FW643,
    JMicron JMB381 --- these do not exhibit this bug.)
    
    Clemens proposed a quirks flag for that, IOW whitelist known misbehaving
    controllers for this workaround.  Though to me it seems harmless enough
    to enable for all controllers.
    
    The log_ar_at_event() debug log will continue to show the original
    status from the DMA unit.
    
    Reported-by: Clemens Ladisch <clemens@ladisch.de> (VT6308)
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    a4dc090b
ohci.c 85.3 KB