• Axel Lin's avatar
    Regulator: lp3972 cleanup · 993af7c0
    Axel Lin authored
    This patch includes below fixes based on Mark's comment.
     - Return actual error if i2c_smbus_read_byte_data() fail
     - Add spaces around bitwise AND operator(&) to improve readability
     - Add comment to explain why we need to update voltage change control register
       for LDO1 and LDO5
     - Logging the value for diagnostics if chip reported incorrect voltage value
     - Add __devinit annotation for setup_regulators()
     - Show system control register1 value if the value is mismatched
     - Logging the value for diagnostics if failed to detect device
    Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
    Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
    Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
    993af7c0
lp3972.c 16.2 KB