• Stephen Boyd's avatar
    firmware: consolidate kmap/read/write logic · 9ccf9811
    Stephen Boyd authored
    Some systems are memory constrained but they need to load very large
    firmwares.  The firmware subsystem allows drivers to request this
    firmware be loaded from the filesystem, but this requires that the
    entire firmware be loaded into kernel memory first before it's provided
    to the driver.  This can lead to a situation where we map the firmware
    twice, once to load the firmware into kernel memory and once to copy the
    firmware into the final resting place.
    
    This design creates needless memory pressure and delays loading because
    we have to copy from kernel memory to somewhere else.  This patch sets
    adds support to the request firmware API to load the firmware directly
    into a pre-allocated buffer, skipping the intermediate copying step and
    alleviating memory pressure during firmware loading.  The drawback is
    that we can't use the firmware caching feature because the memory for
    the firmware cache is not managed by the firmware layer.
    
    This patch (of 3):
    
    We use similar structured code to read and write the kmapped firmware
    pages.  The only difference is read copies from the kmap region and
    write copies to it.  Consolidate this into one function to reduce
    duplication.
    
    Link: http://lkml.kernel.org/r/20160607164741.31849-2-stephen.boyd@linaro.orgSigned-off-by: default avatarStephen Boyd <stephen.boyd@linaro.org>
    Cc: Vikram Mulukutla <markivx@codeaurora.org>
    Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Ming Lei <ming.lei@canonical.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    9ccf9811
firmware_class.c 39.4 KB