• Oleg Nesterov's avatar
    proc: fix ->f_pos overflows in first_tid() · 9f6e963f
    Oleg Nesterov authored
    1. proc_task_readdir()->first_tid() path truncates f_pos to int, this
       is wrong even on 64bit.
    
       We could check that f_pos < PID_MAX or even INT_MAX in
       proc_task_readdir(), but this patch simply checks the potential
       overflow in first_tid(), this check is nop on 64bit.  We do not care if
       it was negative and the new unsigned value is huge, all we need to
       ensure is that we never wrongly return !NULL.
    
    2. Remove the 2nd "nr != 0" check before get_nr_threads(),
       nr_threads == 0 is not distinguishable from !pid_task() above.
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    Cc: "Eric W. Biederman" <ebiederm@xmission.com>
    Cc: Michal Hocko <mhocko@suse.cz>
    Cc: Sameer Nanda <snanda@chromium.org>
    Cc: Sergey Dyasly <dserrg@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    9f6e963f
base.c 76 KB