• Johannes Berg's avatar
    iwlwifi: fix PCI-E transport "inta" race · b49ba04a
    Johannes Berg authored
    When an interrupt comes in, we read the reason
    bits and collect them into "trans_pcie->inta".
    This happens with the spinlock held. However,
    there's a bug resetting this variable -- that
    happens after the spinlock has been released.
    This means that it is possible for interrupts
    to be missed if the reset happens after some
    other interrupt reasons were already added to
    the variable.
    
    I found this by code inspection, looking for a
    reason that we sometimes see random commands
    time out. It seems possible that this causes
    such behaviour, but I can't say for sure right
    now since it happens extremely infrequently on
    my test systems.
    
    Cc: stable@vger.kernel.org [3.2]
    Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
    Signed-off-by: default avatarWey-Yi Guy <wey-yi.w.guy@intel.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    b49ba04a
iwl-trans-pcie-rx.c 43.5 KB