• Dave Hansen's avatar
    x86/pti: Reduce amount of kernel text allowed to be Global · a44ca8f5
    Dave Hansen authored
    commit abb67605203687c8b7943d760638d0301787f8d9
    
    Kees reported to me that I made too much of the kernel image global.
    It was far more than just text:
    
    	I think this is too much set global: _end is after data,
    	bss, and brk, and all kinds of other stuff that could
    	hold secrets. I think this should match what
    	mark_rodata_ro() is doing.
    
    This does exactly that.  We use __end_rodata_hpage_align as our
    marker both because it is huge-page-aligned and it does not contain
    any sections we expect to hold secrets.
    
    Kees's logic was that r/o data is in the kernel image anyway and,
    in the case of traditional distributions, can be freely downloaded
    from the web, so there's no reason to hide it.
    
    Fixes: 8c06c774 (x86/pti: Leave kernel text global for !PCID)
    Reported-by: default avatarKees Cook <keescook@google.com>
    Signed-off-by: default avatarDave Hansen <dave.hansen@linux.intel.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Acked-by: default avatarIngo Molnar <mingo@kernel.org>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Juergen Gross <jgross@suse.com>
    Cc: Josh Poimboeuf <jpoimboe@redhat.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: David Woodhouse <dwmw2@infradead.org>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: linux-mm@kvack.org
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Nadav Amit <namit@vmware.com>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Arjan van de Ven <arjan@linux.intel.com>
    Link: https://lkml.kernel.org/r/20180420222023.1C8B2B20@viggo.jf.intel.com
    
    a44ca8f5
pti.c 12.9 KB