• Jarkko Nikula's avatar
    dmaengine: dw: Fix data corruption in large device to memory transfers · a46a7634
    Jarkko Nikula authored
    When transferring more data than the maximum block size supported by the
    HW multiplied by source width the transfer is split into smaller chunks.
    Currently code calculates the memory width and thus aligment before
    splitting for both memory to device and device to memory transfers.
    
    For memory to device transfers this work fine since alignment is preserved
    through the splitting and split blocks are still memory width aligned.
    However in device to memory transfers aligment breaks when maximum block
    size multiplied by register width doesn't have the same alignment than the
    buffer. For instance when transferring from an 8-bit register 4100 bytes
    (32-bit aligned) on a DW DMA that has maximum block size of 4095 elements.
    An attempt to do such transfers caused data corruption.
    
    Fix this by calculating and setting the destination memory width after
    splitting by using the split block aligment and length.
    Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
    Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
    a46a7634
core.c 42.8 KB