• Eric Dumazet's avatar
    sfc-falcon: remove ndo_poll_controller · a4f570be
    Eric Dumazet authored
    As diagnosed by Song Liu, ndo_poll_controller() can
    be very dangerous on loaded hosts, since the cpu
    calling ndo_poll_controller() might steal all NAPI
    contexts (for all RX/TX queues of the NIC). This capture
    can last for unlimited amount of time, since one
    cpu is generally not able to drain all the queues under load.
    
    sfc-falcon uses NAPI for TX completions, so we better let core
    networking stack call the napi->poll() to avoid the capture.
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Solarflare linux maintainers <linux-net-drivers@solarflare.com>
    Cc: Edward Cree <ecree@solarflare.com>
    Cc: Bert Kenward <bkenward@solarflare.com>
    Acked-By: default avatarBert Kenward <bkenward@solarflare.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    a4f570be
efx.c 83 KB