• Olaf Kirch's avatar
    IB/fmr_pool: Flush serial numbers can get out of sync · a656eb75
    Olaf Kirch authored
    Normally, the serial numbers for flush requests and flushes executed
    for an FMR pool should be in sync.
    
    However, if the FMR pool flushes dirty FMRs because the
    dirty_watermark was reached, we wake up the cleanup thread and let it
    do its stuff.  As a side effect, the cleanup thread increments
    pool->flush_ser, which leaves it one higher than pool->req_ser.  The
    next time the user calls ib_flush_fmr_pool(), the cleanup thread will
    be woken up, but ib_flush_fmr_pool() won't wait for the flush to
    complete because flush_ser is already past req_ser.  This means the
    FMRs that the user expects to be flushed may not have all been flushed
    when the function returns.
    
    Fix this by telling the cleanup thread to do work exclusively by
    incrementing req_ser, and by moving the comparison of dirty_len and
    dirty_watermark into ib_fmr_pool_unmap().
    Signed-off-by: default avatarOlaf Kirch <olaf.kirch@oracle.com>
    a656eb75
fmr_pool.c 13.8 KB