• Roland Dreier's avatar
    powerpc: Avoid integer overflow in page_is_ram() · a880e762
    Roland Dreier authored
    Commit 8b150478 ("ppc: make phys_mem_access_prot() work with pfns
    instead of addresses") fixed page_is_ram() in arch/ppc to avoid overflow
    for addresses above 4G on 32-bit kernels.  However arch/powerpc's
    page_is_ram() is missing the same fix -- it computes a physical address
    by doing pfn << PAGE_SHIFT, which overflows if pfn corresponds to a page
    above 4G.
    
    In particular this causes pages above 4G to be mapped with the wrong
    caching attribute; for example many ppc440-based SoCs have PCI space
    above 4G, and mmap()ing MMIO space may end up with a mapping that has
    caching enabled.
    
    Fix this by working with the pfn and avoiding the conversion to
    physical address that causes the overflow.  This patch compares the
    pfn to max_pfn, which is a semantic change from the old code -- that
    code compared the physical address to high_memory, which corresponds
    to max_low_pfn.  However, I think that was is another bug, since
    highmem pages are still RAM.
    Reported-by: default avatarvb <vb@vsbe.com>
    Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
    Acked-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    a880e762
mem.c 14.9 KB