• Vladimir Oltean's avatar
    net: dsa: sja1105: Don't check state->link in phylink_mac_config · a979a0ab
    Vladimir Oltean authored
    It has been pointed out that PHYLINK can call mac_config only to update
    the phy_interface_type and without knowing what the AN results are.
    
    Experimentally, when this was observed to happen, state->link was also
    unset, and therefore was used as a proxy to ignore this call. However it
    is also suggested that state->link is undefined for this callback and
    should not be relied upon.
    
    So let the previously-dead codepath for SPEED_UNKNOWN be called, and
    update the comment to make sure the MAC's behavior is sane.
    
    Cc: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: default avatarVladimir Oltean <olteanv@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    a979a0ab
sja1105_main.c 61.5 KB