• Tony Lindgren's avatar
    ASoC: Fix twl4030 and 6040 regression by adding back read and write · 8146acff
    Tony Lindgren authored
    Commit 3bb0f7c3 ("ASoC: don't use snd_soc_write/read on twl4030")
    caused regressions for both twl4030 and twl6040 as it assumes the
    ASoC driver is using regmap. As a side effect, this also causes a
    considerable increase in idle power consumption omap3 boards using
    twl4030 as the PMIC.
    
    This is because the removal of read and write function pointers
    causes some of the ASoC IO functions to not do anything. For example,
    snd_soc_register_card() calls snd_soc_dapm_new_widgets() that calls
    snd_soc_codec_drv_read() that now does nothing.
    
    A long term solution suggested by Mark Brown <broonie@kernel.org>
    is to make the twl drivers use regmap by adding a call to
    snd_soc_codec_set_regmap(). This however needs more consideration
    as currently the driver internal reads do caching and we would have
    both regmap access and internal read/write access accessing the same
    hardware registers.
    
    So to fix the regression, let's just do a partial revert adding back
    the read and write function pointers. Note that other non-regmap
    ASoC drivers may need similar patches.
    
    Fixes: 3bb0f7c3 ("ASoC: don't use snd_soc_write/read on twl4030")
    Fixes: 93a00c46 ("ASoC: don't use snd_soc_write/read on twl6040")
    Acked-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    8146acff
twl6040.c 31.5 KB