• Lyude Paul's avatar
    drm/nouveau/kms/nv50-: Limit MST BPC to 8 · ae5769d4
    Lyude Paul authored
    Noticed this while working on some unrelated CRC stuff. Currently,
    userspace has very little support for BPCs higher than 8. While this
    doesn't matter for most things, on MST topologies we need to be careful
    about ensuring that we do our best to make any given display
    configuration fit within the bandwidth restraints of the topology, since
    otherwise less people's monitor configurations will work.
    
    Allowing for BPC settings higher than 8 dramatically increases the
    required bandwidth for displays in most configurations, and consequently
    makes it a lot less likely that said display configurations will pass
    the atomic check.
    
    In the future we want to fix this correctly by making it so that we
    adjust the bpp for each display in a topology to be as high as possible,
    while making sure to lower the bpp of each display in the event that we
    run out of bandwidth and need to rerun our atomic check. But for now,
    follow the behavior that both i915 and amdgpu are sticking to.
    Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
    Fixes: 232c9eec ("drm/nouveau: Use atomic VCPI helpers for MST")
    Cc: Ben Skeggs <bskeggs@redhat.com>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Cc: David Airlie <airlied@redhat.com>
    Cc: Jerry Zuo <Jerry.Zuo@amd.com>
    Cc: Harry Wentland <harry.wentland@amd.com>
    Cc: Juston Li <juston.li@intel.com>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Sean Paul <seanpaul@chromium.org>
    Cc: <stable@vger.kernel.org> # v5.1+
    Signed-off-by: default avatarBen Skeggs <bskeggs@redhat.com>
    ae5769d4
disp.c 63.7 KB