• Ian Kent's avatar
    autofs - remove obsolete d_invalidate() from expire · b3ca406f
    Ian Kent authored
    Biederman's umount-on-rmdir series changes d_invalidate() to sumarily remove
    mounts under the passed in dentry regardless of whether they are busy
    or not. So calling this in fs/autofs4/expire.c:autofs4_tree_busy() is
    definitely the wrong thing to do becuase it will silently umount entries
    instead of just cleaning stale dentrys.
    
    But this call shouldn't be needed and testing shows that automounting
    continues to function without it.
    
    As Al Viro correctly surmises the original intent of the call was to
    perform what shrink_dcache_parent() does.
    
    If at some time in the future I see stale dentries accumulating
    following failed mounts I'll revisit the issue and possibly add a
    shrink_dcache_parent() call if needed.
    Signed-off-by: default avatarIan Kent <raven@themaw.net>
    Cc: Al Viro <viro@ZenIV.linux.org.uk>
    Cc: Eric W. Biederman <ebiederm@xmission.com>
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    b3ca406f
expire.c 13.4 KB