• Guilherme G. Piccoli's avatar
    powerpc/xmon: drop the nobt option from xmon plus minor fixes · b561783c
    Guilherme G. Piccoli authored
    The xmon parameter nobt was added long time ago, by commit 26c8af5f
    ("[POWERPC] print backtrace when entering xmon"). The problem that time
    was that during a crash in a machine with USB keyboard, xmon wouldn't
    respond to commands from the keyboard, so printing the backtrace wouldn't
    be possible.
    
    Idea then was to show automatically the backtrace on xmon crash for the
    first time it's invoked (if it recovers, next time xmon won't show
    backtrace automatically). The nobt parameter was added _only_ to prevent
    this automatic trace show. Seems long time ago USB keyboards didn't work
    that well!
    
    We don't need this parameter anymore, the feature of auto showing the
    backtrace is interesting (imagine a case of auto-reboot script),
    so this patch extends the functionality, by always showing the backtrace
    automatically when xmon is invoked; it removes the nobt parameter too.
    
    Also, this patch fixes __initdata placement on xmon_early and replaces
    __initcall() with modern device_initcall() on sysrq handler.
    Signed-off-by: default avatarGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    b561783c
xmon.c 76.4 KB