• Javi Merino's avatar
    ARM: 7136/1: pl330: Fix a race condition · ee3f6158
    Javi Merino authored
    If two requests have been submitted and one of them is running, if you
    call pl330_chan_ctrl(ch_id, PL330_OP_START), there's a window of time
    between the spin_lock_irqsave() and the _state() check in which the
    running transaction may finish.  In that case, we don't receive the
    interrupt (because they are disabled), but _start() sees that the DMA
    is stopped, so it starts it.  The problem is that it sends the
    transaction that has just finished again, because pl330_update()
    hasn't mark it as done yet.
    
    This patch fixes this race condition by not calling _start() if the
    DMA is already executing transactions.  When interrupts are reenabled,
    pl330_update() will call _start().
    
    Reference: <1317892206-3600-1-git-send-email-javi.merino@arm.com>
    Signed-off-by: default avatarJavi Merino <javi.merino@arm.com>
    Acked-by: default avatarJassi Brar <jassi.brar@samsung.com>
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    ee3f6158
pl330.c 41.3 KB