• Tejun Heo's avatar
    sata_sil24: freeze on non-dev errors reported via CERR · c2e14f11
    Tejun Heo authored
    CERR reports errors detected during executing a command.  This doesn't
    mean the error is tied to the command and can be recovered by just
    issuing it again.  Many of the errors are fatal port-wide connditions
    including HSM violation, host bus error and ATA bus error and require
    freezing and port reset.
    
    The freezing part wasn't implemented previously.  This used to be okay
    because port resets were scheduled anyway and EH eventually resets and
    recovers the port.  With PMP support added, this is no longer true.
    The error condition and recover actions are attributed to the fan-out
    port and the host port condition isn't properly recovered leading to
    EH failures.
    
    This patch makes CERR errors which require resets to freeze the port.
    This will force host port reset and proper recovery.
    Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
    Cc: Andrew Ryder <tireman@shaw.ca>
    Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
    c2e14f11
sata_sil24.c 39.3 KB