• Rasmus Villemoes's avatar
    x86/mm/mtrr: Mark the 'range_new' static variable in mtrr_calc_range_state() as __initdata · c332813b
    Rasmus Villemoes authored
    'range_new' doesn't seem to be used after init. It is only passed
    to memset(), sum_ranges(), memcmp() and x86_get_mtrr_mem_range(), the
    latter of which also only passes it on to various *range*
    library functions.
    
    So mark it __initdata to free up an extra page after init.
    
    Its contents are wiped at every call to mtrr_calc_range_state(),
    so it being static is not about preserving state between calls,
    but simply to avoid a 4k+ stack frame. While there, add a
    comment explaining this and why it's safe.
    
    We could also mark nr_range_new as __initdata, but since it's
    just a single int and also doesn't carry state between calls (it
    is unconditionally assigned to before it is read), we might as
    well make it an ordinary automatic variable.
    Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Toshi Kani <toshi.kani@hp.com>
    Link: http://lkml.kernel.org/r/1449002691-20783-1-git-send-email-linux@rasmusvillemoes.dkSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    c332813b
cleanup.c 25.1 KB