• Eric W. Biederman's avatar
    tun: Fix races between tun_net_close and free_netdev. · c70f1829
    Eric W. Biederman authored
    The tun code does not cope gracefully if the network device goes away before
    the tun file descriptor is closed.  It looks like we can trigger this with
    rmmod, and moving tun devices between network namespaces will allow this
    to be triggered when network namespaces exit.
    
    To fix this I introduce an intermediate data structure tun_file which
    holds a count of users and a pointer to the struct tun_struct.  tun_get
    increments that reference count if it is greater than 0.  tun_put decrements
    that reference count and detaches from the network device if the count is 0.
    
    While we have a file attached to the network device I hold a reference
    to the network device keeping it from going away completely.
    
    When a network device is unregistered I decrement the count of the
    attached tun_file and if that was the last user I detach the tun_file,
    and all processes on read_wait are woken up to ensure they do not
    sleep indefinitely. As some of those sleeps happen with the count on
    the tun device elevated waking up the read waiters ensures that
    tun_file will be detached in a timely manner.
    Signed-off-by: default avatarEric W. Biederman <ebiederm@aristanetworks.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c70f1829
tun.c 29.9 KB