• Wenwen Wang's avatar
    ALSA: firewire: fix a memory leak bug · 1be3c1fa
    Wenwen Wang authored
    In iso_packets_buffer_init(), 'b->packets' is allocated through
    kmalloc_array(). Then, the aligned packet size is checked. If it is
    larger than PAGE_SIZE, -EINVAL will be returned to indicate the error.
    However, the allocated 'b->packets' is not deallocated on this path,
    leading to a memory leak.
    
    To fix the above issue, free 'b->packets' before returning the error code.
    
    Fixes: 31ef9134 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver")
    Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
    Reviewed-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
    Cc: <stable@vger.kernel.org> # v2.6.39+
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    1be3c1fa
packets-buffer.c 2.05 KB