• Mark Brown's avatar
    Merge series "ASoC: Intel: fix cppcheck warnings" from Pierre-Louis Bossart... · 5ca8f9a5
    Mark Brown authored
    Merge series "ASoC: Intel: fix cppcheck warnings" from Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>:
    
    This patchset tries to reduce the number of warnings on those drivers,
    so that cppcheck can become a viable tool to detect issues (currently
    hundreds of reports).
    
    Most of the problems are related to unnecessary/redundant variable
    assignments, prototypes and one nice logical mistake resulting in an
    always-true condition.
    
    Pierre-Louis Bossart (21):
      ASoC: Intel: Atom: sst-atom-controls: remove redundant assignments
      ASoC: Intel: Atom: compress: remove redundant assignment
      ASoC: Intel: Atom: platform-pcm: remove redundant assignment
      ASoC: Intel: Atom: sst: remove useless NULL assignment
      ASoC: Intel: Atom: remove redundant initialization
      ASoC: Intel: Atom: sst_pvt: remove redundant initialization
      ASoC: Intel: Atom: platform-pcm: fix redundant return
      ASoC: Intel: Atom: remove useless assignment
      ASoC: Intel: Atom: sst_loader: remove always-true condition
      ASoC: Intel: Atom: sst_pvt: simplify return handling
      ASoC: Intel: Atom: (cosmetic) align parameters
      ASoC: Intel: Baytrail: (cosmetic) align function parameters
      ASoC: Intel: common: (cosmetic) align function parameters
      ASoC: Intel: haswell: (cosmetic) align function parameters
      ASoC: Intel: haswell-ipc: remove redundant assignments
      ASoC: Intel: Skylake: skl-nhlt: remove redundant initialization
      ASoC: Intel: Skylake: cldma: remove redundant initialization
      ASoC: Intel: Skylake: sst-utils: remove redundant assignment
      ASoC: Intel: Skylake: skl-topology: remove redundant assignments
      ASoC: Intel: Skylake: skl-topology: remove redundant assignment
      ASoC: Intel: Skylake: (cosmetic) align function parameters
    
     sound/soc/intel/atom/sst-atom-controls.c      |  4 +--
     .../intel/atom/sst-mfld-platform-compress.c   |  3 +-
     sound/soc/intel/atom/sst-mfld-platform-pcm.c  |  4 +--
     sound/soc/intel/atom/sst-mfld-platform.h      |  4 +--
     sound/soc/intel/atom/sst/sst.c                |  5 ++-
     sound/soc/intel/atom/sst/sst.h                | 34 +++++++++----------
     sound/soc/intel/atom/sst/sst_loader.c         |  3 +-
     sound/soc/intel/atom/sst/sst_pvt.c            |  4 +--
     sound/soc/intel/baytrail/sst-baytrail-ipc.h   |  3 +-
     sound/soc/intel/common/sst-dsp-priv.h         |  2 +-
     sound/soc/intel/common/sst-dsp.h              | 15 ++++----
     sound/soc/intel/haswell/sst-haswell-ipc.c     |  4 +--
     sound/soc/intel/haswell/sst-haswell-ipc.h     |  2 +-
     sound/soc/intel/skylake/cnl-sst-dsp.h         |  4 +--
     sound/soc/intel/skylake/skl-nhlt.c            |  2 +-
     sound/soc/intel/skylake/skl-sst-cldma.c       |  2 +-
     sound/soc/intel/skylake/skl-sst-ipc.h         | 16 ++++-----
     sound/soc/intel/skylake/skl-sst-utils.c       |  2 +-
     sound/soc/intel/skylake/skl-topology.c        |  8 ++---
     sound/soc/intel/skylake/skl-topology.h        |  8 ++---
     sound/soc/intel/skylake/skl.h                 |  2 +-
     21 files changed, 63 insertions(+), 68 deletions(-)
    
    --
    2.25.1
    5ca8f9a5
sst-haswell-ipc.c 56.9 KB