• Jason Gerecke's avatar
    HID: wacom: Correct coordinate system of touchring and pen twist · d252f4a1
    Jason Gerecke authored
    The MobileStudio Pro, Cintiq Pro, and 2nd-gen Intuos Pro devices use a
    different coordinate system for their touchring and pen twist than prior
    devices. Prior devices had zero aligned to the tablet's left and would
    increase clockwise. Userspace expects data from the kernel to be in this
    old coordinate space, so adjustments are necessary.
    
    While the coordinate system for pen twist is formally defined by the HID
    standard, no such definition existed for the touchring at the time these
    tablets were introduced. Future tablets are expected to report touchring
    data using the same "zero-up clockwise-increasing" coordinate system
    defined for twist.
    
    Fixes: 50066a04 ("HID: wacom: generic: Add support for height, tilt, and twist usages")
    Fixes: 4922cd26 ("HID: wacom: Support 2nd-gen Intuos Pro's Bluetooth classic interface")
    Fixes: 60a22186 ("HID: wacom: generic: add support for touchring")
    Cc: stable@vger.kernel.org # 4.10, 4.11
    Signed-off-by: default avatarJason Gerecke <jason.gerecke@wacom.com>
    Reviewed-by: default avatarPing Cheng <ping.cheng@wacom.com>
    Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
    d252f4a1
wacom_wac.c 142 KB