• Sibi Sankar's avatar
    remoteproc: qcom: q6v5: Fix a race condition on fatal crash · d3ae96c0
    Sibi Sankar authored
    Currently with GLINK_SSR enabled each fatal crash results in servicing
    a crash from wdog as well. This is due to a race that occurs in setting
    the running flag in the shutdown path. Fix this by moving the running
    flag to the end of fatal interrupt handler.
    
    Crash Logs:
    qcom-q6v5-pil 4080000.remoteproc: fatal error without message
    remoteproc remoteproc0: crash detected in 4080000.remoteproc: type fatal
    	error
    remoteproc remoteproc0: handling crash #1 in 4080000.remoteproc
    remoteproc remoteproc0: recovering 4080000.remoteproc
    qcom-q6v5-pil 4080000.remoteproc: watchdog without message
    remoteproc remoteproc0: crash detected in 4080000.remoteproc: type watchdog
    remoteproc:glink-edge: intent request timed out
    qcom_glink_ssr remoteproc:glink-edge.glink_ssr.-1.-1: failed to send
    	cleanup message
    qcom_glink_ssr remoteproc:glink-edge.glink_ssr.-1.-1: timeout waiting
    	for cleanup done message
    qcom-q6v5-pil 4080000.remoteproc: timed out on wait
    qcom-q6v5-pil 4080000.remoteproc: port failed halt
    remoteproc remoteproc0: stopped remote processor 4080000.remoteproc
    qcom-q6v5-pil 4080000.remoteproc: MBA booted, loading mpss
    remoteproc remoteproc0: remote processor 4080000.remoteproc is now up
    remoteproc remoteproc0: handling crash #2 in 4080000.remoteproc
    remoteproc remoteproc0: recovering 4080000.remoteproc
    qcom-q6v5-pil 4080000.remoteproc: port failed halt
    remoteproc remoteproc0: stopped remote processor 4080000.remoteproc
    qcom-q6v5-pil 4080000.remoteproc: MBA booted, loading mpss
    remoteproc remoteproc0: remote processor 4080000.remoteproc is now up
    Suggested-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: default avatarSibi Sankar <sibis@codeaurora.org>
    Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    d3ae96c0
qcom_q6v5.c 6.72 KB