• Daniel Vetter's avatar
    drm/i915: don't trylock in the gpu reset code · d54a02c0
    Daniel Vetter authored
    Simply failing to reset the gpu because someone else might still hold
    the mutex isn't a great idea - I see reliable silent reset failures.
    And gpu reset simply needs to be reliable and Just Work.
    
    "But ... the deadlocks!"
    
    We already kick all processes waiting for the gpu before launching the
    reset work item. New waiters need to check the wedging state anyway
    and then bail out. If we have places that can deadlock, we simply need
    to fix them.
    
    "But ... testing!"
    
    We have the gpu hangman, and if the current gpu load gem_exec_nop
    isn't good enough to hit a specific case, we can add a new one.
    
    "But ...  don't we return -EAGAIN for non-interruptible calls to
    wait_seqno now?"
    
    Yep, but this problem already exists in the current code. A follow up
    patch will remedy this by returning -EIO for non-interruptible sleeps
    if the gpu died and the low-level wait bails out with -EAGAIN.
    Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Tested-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Signed-Off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    d54a02c0
i915_drv.c 31.6 KB