• Nick Piggin's avatar
    inotify: fix race · d599e36a
    Nick Piggin authored
    There is a race between setting an inode's children's "parent watched" flag
    when placing the first watch on a parent, and instantiating new children of
    that parent: a child could miss having its flags set by
    set_dentry_child_flags, but then inotify_d_instantiate might still see
    !inotify_inode_watched.
    
    The solution is to set_dentry_child_flags after adding the watch.  Locking is
    taken care of, because both set_dentry_child_flags and inotify_d_instantiate
    hold dcache_lock and child->d_locks.
    Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
    Cc: Robert Love <rlove@google.com>
    Cc: John McCutchan <ttb@tentacle.dhs.org>
    Cc: Jan Kara <jack@ucw.cz>
    Cc: Yan Zheng <yanzheng@21cn.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    d599e36a
inotify.c 20.4 KB