• Rafael J. Wysocki's avatar
    PM / Sleep: Fix race conditions related to wakeup source timer function · da863cdd
    Rafael J. Wysocki authored
    If __pm_wakeup_event() has been used (with a nonzero timeout) to
    report a wakeup event and then __pm_relax() immediately followed by
    __pm_stay_awake() is called or __pm_wakeup_event() is called once
    again for the same wakeup source object before its timer expires, the
    timer function pm_wakeup_timer_fn() may still be run as a result of
    the previous __pm_wakeup_event() call.  In either of those cases it
    may mistakenly deactivate the wakeup source that has just been
    activated.
    
    To prevent that from happening, make wakeup_source_deactivate()
    clear the wakeup source's timer_expires field and make
    pm_wakeup_timer_fn() check if timer_expires is different from zero
    and if it's not in future before calling wakeup_source_deactivate()
    (if timer_expires is 0, it means that the timer has just been
    deleted and if timer_expires is in future, it means that the timer
    has just been rescheduled to a different time).
    Reported-by: default avatarArve Hjønnevåg <arve@android.com>
    Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
    da863cdd
wakeup.c 20.5 KB