• Alexander Sverdlin's avatar
    MIPS: octeon: Fix GPIO number in IRQ chip private data · d41d547a
    Alexander Sverdlin authored
    Current GPIO chip implementation in octeon-irq is still broken, even after upstream
    commit 87161ccd (MIPS: Octeon: Fix broken interrupt
    controller code). It works for GPIO IRQs that have reset-default configuration, but
    not for edge-triggered ones.
    
    The problem is in octeon_irq_gpio_map_common(), which passes modified "hw" variable
    (which has range of possible values 16..31) as "gpio_line" parameter to
    octeon_irq_set_ciu_mapping(), which saves it in private data of the IRQ chip. Later,
    neither octeon_irq_gpio_setup() is able to re-configure GPIOs (cvmx_write_csr() is
    writing to non-existent CVMX_GPIO_BIT_CFGX), nor octeon_irq_ciu_gpio_ack() is able
    to acknowledge such IRQ, because "mask" is incorrect.
    
    Fix is trivial and has been tested on Cavium Octeon II -based board, including
    both level-triggered and edge-triggered GPIO IRQs.
    Signed-off-by: default avatarAlexander Sverdlin <alexander.sverdlin.ext@nsn.com>
    Cc: David Daney <david.daney@cavium.com>
    Acked-by: default avatarDavid Daney <david.daney@cavium.com>
    Patchwork: http://patchwork.linux-mips.org/patch/4980/Acked-by: default avatarJohn Crispin <blogic@openwrt.org>
    d41d547a
octeon-irq.c 44.1 KB