• Denis Kirjanov's avatar
    KVM: PPC: Book3S HV: Avoid preemptibility warning in module initialization · db4b0dfa
    Denis Kirjanov authored
    With CONFIG_DEBUG_PREEMPT, get_paca() produces the following warning
    in kvmppc_book3s_init_hv() since it calls debug_smp_processor_id().
    
    There is no real issue with the xics_phys field.
    If paca->kvm_hstate.xics_phys is non-zero on one cpu, it will be
    non-zero on them all.  Therefore this is not fixing any actual
    problem, just the warning.
    
    [  138.521188] BUG: using smp_processor_id() in preemptible [00000000] code: modprobe/5596
    [  138.521308] caller is .kvmppc_book3s_init_hv+0x184/0x350 [kvm_hv]
    [  138.521404] CPU: 5 PID: 5596 Comm: modprobe Not tainted 4.11.0-rc3-00022-gc7e790c5 #1
    [  138.521509] Call Trace:
    [  138.521563] [c0000007d018b810] [c0000000023eef10] .dump_stack+0xe4/0x150 (unreliable)
    [  138.521694] [c0000007d018b8a0] [c000000001f6ec04] .check_preemption_disabled+0x134/0x150
    [  138.521829] [c0000007d018b940] [d00000000a010274] .kvmppc_book3s_init_hv+0x184/0x350 [kvm_hv]
    [  138.521963] [c0000007d018ba00] [c00000000191d5cc] .do_one_initcall+0x5c/0x1c0
    [  138.522082] [c0000007d018bad0] [c0000000023e9494] .do_init_module+0x84/0x240
    [  138.522201] [c0000007d018bb70] [c000000001aade18] .load_module+0x1f68/0x2a10
    [  138.522319] [c0000007d018bd20] [c000000001aaeb30] .SyS_finit_module+0xc0/0xf0
    [  138.522439] [c0000007d018be30] [c00000000191baec] system_call+0x38/0xfc
    Signed-off-by: default avatarDenis Kirjanov <kda@linux-powerpc.org>
    Signed-off-by: default avatarPaul Mackerras <paulus@ozlabs.org>
    db4b0dfa
book3s_hv.c 101 KB