• Naftali Goldstein's avatar
    iwlwifi: runtime: avoid calling debugfs read functions more than once · dd269057
    Naftali Goldstein authored
    Upon first calling read() on a debugfs file, invoke
    iwl_dbgfs_##name##_read and store the response buffer on the heap, so
    subsequent read() calls don't need to invoke said function again.
    
    This is done because cat etc will call read() repeatedly until EOF is
    reached (or read() returns 0), which in the current implementation will
    cause said function to be invoked multiple times.
    
    With the current implementation this can also cause buggy behavior in
    some weird edge cases where the first invocation returns a string of
    length n, and the second of length m>n: The last m-n characters of
    the second invocation will be printed to screen.
    Signed-off-by: default avatarNaftali Goldstein <naftali.goldstein@intel.com>
    Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
    dd269057
debugfs.c 8.79 KB