• Jarod Wilson's avatar
    [media] ite-cir: 8709 needs to use pnp resource 2 · 35d136c8
    Jarod Wilson authored
    Thanks to the intrepid testing and debugging of Matthijs van Drunen, it
    was uncovered that at least some variants of the ITE8709 need to use pnp
    resource 2, rather than 0, for things to function properly. Resource 0
    has a length of only 1, and if you try to bypass the pnp_port_len check
    and use it anyway (with either a length of 1 or 2), the system in
    question's trackpad ceased to function.
    
    The circa lirc 0.8.7 lirc_ite8709 driver used resource 2, but the value
    was (amusingly) changed to 0 by way of a patch from ITE themselves, so I
    don't know if there may be variants where 0 actually *is* correct, but
    at least in this case and in the original lirc_ite8709 driver author's
    case, it sure looks like 2 is the right value.
    
    This fix should probably be applied to all stable kernels with the
    ite-cir driver, lest we nuke more people's trackpads.
    
    Tested-by: Matthijs van Drunen
    CC: Juan Jesús García de Soria <skandalfo@gmail.com>
    CC: stable@kernel.org
    Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
    35d136c8
ite-cir.c 46.2 KB