• Stephen Rothwell's avatar
    xilinx_uartps.c: suppress "may be used uninitialised" warning · 2bf593f1
    Stephen Rothwell authored
    A powerpc allyesconfig build produces this warning:
    
    In file included from include/linux/radix-tree.h:16,
                     from include/linux/idr.h:15,
                     from include/linux/kernfs.h:13,
                     from include/linux/sysfs.h:16,
                     from include/linux/kobject.h:20,
                     from include/linux/device.h:16,
                     from include/linux/platform_device.h:13,
                     from drivers/tty/serial/xilinx_uartps.c:16:
    drivers/tty/serial/xilinx_uartps.c: In function 'cdns_uart_console_write':
    include/linux/spinlock.h:288:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
       _raw_spin_unlock_irqrestore(lock, flags); \
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    drivers/tty/serial/xilinx_uartps.c:1197:16: note: 'flags' was declared here
      unsigned long flags;
                    ^~~~~
    
    It looks like gcc just can't track the relationship between "locked"
    and "flags", and it is obvious that "flags" won't be used when "locked"
    is zero, so the simplest thing is to initialise flags.
    
    Cc: Jiri Slaby <jslaby@suse.com>
    Cc: Michal Simek <michal.simek@xilinx.com>
    Signed-off-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
    Link: https://lore.kernel.org/r/20190731160557.6a09c3e1@canb.auug.org.auSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2bf593f1
xilinx_uartps.c 50.5 KB