• Zhouyi Zhou's avatar
    NFS:remove redundant call to nfs_do_access · eb095c14
    Zhouyi Zhou authored
    In function nfs_permission:
    1. the rcu_read_lock and rcu_read_unlock around nfs_do_access
    is unnecessary because the rcu critical data structure is already
    protected in subsidiary function nfs_access_get_cached_rcu. No other
    data structure needs rcu_read_lock in nfs_do_access.
    
    2. call nfs_do_access once is enough, because:
    2-1. when mask has MAY_NOT_BLOCK bit
    The second call to nfs_do_access will not happen.
    
    2-2. when mask has no MAY_NOT_BLOCK bit
    The second call to nfs_do_access will happen if res == -ECHILD, which
    means the first nfs_do_access goes out after statement if (!may_block).
    The second call to nfs_do_access will go through this procedure once
    again except continue the work after if (!may_block).
    But above work can be performed by only one call to nfs_do_access
    without mangling the mask flag.
    
    Tested in x86_64
    Signed-off-by: default avatarZhouyi Zhou <zhouzhouyi@gmail.com>
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
    eb095c14
dir.c 70.2 KB