• Jian-Hong Pan's avatar
    rtw88: pci: Rearrange the memory usage for skb in RX ISR · ee6db78f
    Jian-Hong Pan authored
    Testing with RTL8822BE hardware, when available memory is low, we
    frequently see a kernel panic and system freeze.
    
    First, rtw_pci_rx_isr encounters a memory allocation failure (trimmed):
    
    rx routine starvation
    WARNING: CPU: 7 PID: 9871 at drivers/net/wireless/realtek/rtw88/pci.c:822 rtw_pci_rx_isr.constprop.25+0x35a/0x370 [rtwpci]
    [ 2356.580313] RIP: 0010:rtw_pci_rx_isr.constprop.25+0x35a/0x370 [rtwpci]
    
    Then we see a variety of different error conditions and kernel panics,
    such as this one (trimmed):
    
    rtw_pci 0000:02:00.0: pci bus timeout, check dma status
    skbuff: skb_over_panic: text:00000000091b6e66 len:415 put:415 head:00000000d2880c6f data:000000007a02b1ea tail:0x1df end:0xc0 dev:<NULL>
    ------------[ cut here ]------------
    kernel BUG at net/core/skbuff.c:105!
    invalid opcode: 0000 [#1] SMP NOPTI
    RIP: 0010:skb_panic+0x43/0x45
    
    When skb allocation fails and the "rx routine starvation" is hit, the
    function returns immediately without updating the RX ring. At this
    point, the RX ring may continue referencing an old skb which was already
    handed off to ieee80211_rx_irqsafe(). When it comes to be used again,
    bad things happen.
    
    This patch allocates a new, data-sized skb first in RX ISR. After
    copying the data in, we pass it to the upper layers. However, if skb
    allocation fails, we effectively drop the frame. In both cases, the
    original, full size ring skb is reused.
    
    In addition, to fixing the kernel crash, the RX routine should now
    generally behave better under low memory conditions.
    
    Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=204053Signed-off-by: default avatarJian-Hong Pan <jian-hong@endlessm.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    ee6db78f
pci.c 30.2 KB