• Shiraz Saleem's avatar
    RDMA/i40iw: Remove MSS change support · f300ba2d
    Shiraz Saleem authored
    MSS change on active QPs is not supported. Store new MSS
    value for new QPs only. Remove code to modify MSS on the fly.
    This also resolves a crash on QP modify to QP 0.
    
    BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
    IP: i40iw_sc_qp_modify+0x22/0x280 [i40iw]
    Oops: 0000 [#1] SMP KASAN
    CPU: 2 PID: 1236 Comm: kworker/u16:4 Not tainted 4.12.0-rc1 #5
    Hardware name: Gigabyte Technology Co., Ltd. To be filled by O.E.M./Q87M-D2H,
    BIOS F7 01/17/2014
    Workqueue: l2params i40iw_l2params_worker [i40iw]
    task: ffff88070f5a9b40 task.stack: ffff88070f5a0000
    RIP: 0010:i40iw_sc_qp_modify+0x22/0x280 [i40iw]
    ...
    Call Trace:
    i40iw_exec_cqp_cmd+0x2ce/0x410 [i40iw]
    ? _raw_spin_lock_irqsave+0x6f/0x80
    ? i40iw_process_cqp_cmd+0x1d/0x80 [i40iw]
    i40iw_process_cqp_cmd+0x7c/0x80 [i40iw]
    i40iw_handle_cqp_op+0x2f/0x200 [i40iw]
    ? trace_hardirqs_off+0xd/0x10
    ? _raw_spin_unlock_irqrestore+0x46/0x50
    i40iw_hw_modify_qp+0x5e/0x90 [i40iw]
    i40iw_qp_mss_modify+0x52/0x60 [i40iw]
    i40iw_change_l2params+0x145/0x160 [i40iw]
    i40iw_l2params_worker+0x1f/0x40 [i40iw]
    process_one_work+0x1f5/0x650
    ? process_one_work+0x161/0x650
    worker_thread+0x48/0x3b0
    kthread+0x112/0x150
    ? process_one_work+0x650/0x650
    ? kthread_create_on_node+0x40/0x40
    ret_from_fork+0x2e/0x40
    Code: 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 41 56 41 55 41 89 cd 41 54 49 89 fc
    53 48 89 f3 48 89 d6 48 83 ec 08 48 8b 87 10 01 00 00 <48> 8b 40 08 4c 8b b0 40 04
    00 00 4c 89 f7 e8 1b e5 ff ff 48 85
    RIP: i40iw_sc_qp_modify+0x22/0x280 [i40iw] RSP: ffff88070f5a7c28
    CR2: 0000000000000008
    ---[ end trace 77a405931e296060 ]---
    Reported-by: default avatarStefan Assmann <sassmann@redhat.com>
    Signed-off-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
    Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
    f300ba2d
i40iw_utils.c 38.5 KB