• Ido Yariv's avatar
    wl12xx: Remove obsolete testmode NVS push command · 80900d01
    Ido Yariv authored
    The testmode NVS push command is no longer in use. In addition, it has
    several implementation issues that prevent it from working correctly:
    
    1. wl1271_tm_cmd_configure relies on wl->chip.id being set. However,
       since the device was not necessarily booted by the time the function
       is called, wl->chip.id will be initialized to 0.
    2. The NVS file is fetched by calling request_firmware() before it is
       possible to push an NVS file.
    3. The maximum allowed size of nl binary payloads is not sufficient for
       pushing NVS files.
    4. Pushing 128x NVS files will always fail due to a bug in the
       validation code.
    5. In case the pushed NVS file is found invalid, the mutex will be kept
       locked and the nvs member will become a dangling pointer.
    
    Since this feature is not being used, remove it completely instead of
    fixing it.
    Signed-off-by: default avatarIdo Yariv <ido@wizery.com>
    Acked-by: default avatarLuciano Coelho <coelho@ti.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    80900d01
testmode.c 5.64 KB