• Nick Piggin's avatar
    [PATCH] inotify: read return val fix · f9e4acf3
    Nick Piggin authored
    Fix for inotify read bug (bugzilla.kernel.org #6999)
    
    Problem Description:
    When reading from an inotify device with an insufficient sized buffer, read(2)
    will return 0 with no errno set. This is because of an logically incorrect
    action from the user program thus should return an more logical value. My
    suggestion is return -EINVAL as for bind(2).
    
    This patch is based on the proposal from Ryan <wolf0403@hotmail.com>, and
    feedback from John McCutchan <john@johnmccutchan.com>.
    
    Return -EINVAL if we have not passed in enough buffer space to read a single
    inotify event, rather than 0 which indicates that there is nothing to read.
    Signed-off-by: default avatarNick Piggin <npiggin@suse.de>
    Acked-by: default avatar"John McCutchan" <john@johnmccutchan.com>
    Cc: Ryan <wolf0403@hotmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f9e4acf3
inotify_user.c 17.5 KB