• J. Bruce Fields's avatar
    nfsd4: delay filling in write iovec array till after xdr decoding · ffe1137b
    J. Bruce Fields authored
    Our server rejects compounds containing more than one write operation.
    It's unclear whether this is really permitted by the spec; with 4.0,
    it's possibly OK, with 4.1 (which has clearer limits on compound
    parameters), it's probably not OK.  No client that we're aware of has
    ever done this, but in theory it could be useful.
    
    The source of the limitation: we need an array of iovecs to pass to the
    write operation.  In the worst case that array of iovecs could have
    hundreds of elements (the maximum rwsize divided by the page size), so
    it's too big to put on the stack, or in each compound op.  So we instead
    keep a single such array in the compound argument.
    
    We fill in that array at the time we decode the xdr operation.
    
    But we decode every op in the compound before executing any of them.  So
    once we've used that array we can't decode another write.
    
    If we instead delay filling in that array till the time we actually
    perform the write, we can reuse it.
    
    Another option might be to switch to decoding compound ops one at a
    time.  I considered doing that, but it has a number of other side
    effects, and I'd rather fix just this one problem for now.
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    ffe1137b
nfs4xdr.c 90.1 KB