Commit 0020f5c8 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller

net: socionext: Fix two sleep-in-atomic-context bugs in ave_rxfifo_reset()

The driver may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.17 are:

[FUNC] usleep_range
drivers/net/ethernet/socionext/sni_ave.c, 892:
	usleep_range in ave_rxfifo_reset
drivers/net/ethernet/socionext/sni_ave.c, 932:
	ave_rxfifo_reset in ave_irq_handler

[FUNC] usleep_range
drivers/net/ethernet/socionext/sni_ave.c, 888:
	usleep_range in ave_rxfifo_reset
drivers/net/ethernet/socionext/sni_ave.c, 932:
	ave_rxfifo_reset in ave_irq_handler

To fix these bugs, usleep_range() is replaced with udelay().

These bugs are found by my static analysis tool DSAC.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5d288b88
...@@ -895,11 +895,11 @@ static void ave_rxfifo_reset(struct net_device *ndev) ...@@ -895,11 +895,11 @@ static void ave_rxfifo_reset(struct net_device *ndev)
/* assert reset */ /* assert reset */
writel(AVE_GRR_RXFFR, priv->base + AVE_GRR); writel(AVE_GRR_RXFFR, priv->base + AVE_GRR);
usleep_range(40, 50); udelay(50);
/* negate reset */ /* negate reset */
writel(0, priv->base + AVE_GRR); writel(0, priv->base + AVE_GRR);
usleep_range(10, 20); udelay(20);
/* negate interrupt status */ /* negate interrupt status */
writel(AVE_GI_RXOVF, priv->base + AVE_GISR); writel(AVE_GI_RXOVF, priv->base + AVE_GISR);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment