Commit 05b7639d authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso

netfilter: nft_set_rbtree: check for inactive element after flag mismatch

Otherwise, we hit bogus ENOENT when removing elements.

Fixes: e701001e ("netfilter: nft_rbtree: allow adjacent intervals with dynamic updates")
Reported-by: default avatarVáclav Zindulka <vaclav.zindulka@tlapnet.cz>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 29b0b5d5
...@@ -308,10 +308,6 @@ static void *nft_rbtree_deactivate(const struct net *net, ...@@ -308,10 +308,6 @@ static void *nft_rbtree_deactivate(const struct net *net,
else if (d > 0) else if (d > 0)
parent = parent->rb_right; parent = parent->rb_right;
else { else {
if (!nft_set_elem_active(&rbe->ext, genmask)) {
parent = parent->rb_left;
continue;
}
if (nft_rbtree_interval_end(rbe) && if (nft_rbtree_interval_end(rbe) &&
!nft_rbtree_interval_end(this)) { !nft_rbtree_interval_end(this)) {
parent = parent->rb_left; parent = parent->rb_left;
...@@ -320,6 +316,9 @@ static void *nft_rbtree_deactivate(const struct net *net, ...@@ -320,6 +316,9 @@ static void *nft_rbtree_deactivate(const struct net *net,
nft_rbtree_interval_end(this)) { nft_rbtree_interval_end(this)) {
parent = parent->rb_right; parent = parent->rb_right;
continue; continue;
} else if (!nft_set_elem_active(&rbe->ext, genmask)) {
parent = parent->rb_left;
continue;
} }
nft_rbtree_flush(net, set, rbe); nft_rbtree_flush(net, set, rbe);
return rbe; return rbe;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment