Commit 0b9173f4 authored by Marco Oliverio's avatar Marco Oliverio Committed by Pablo Neira Ayuso

netfilter: nf_queue: enqueue skbs with NULL dst

Bridge packets that are forwarded have skb->dst == NULL and get
dropped by the check introduced by
b60a7738 (net: make skb_dst_force
return true when dst is refcounted).

To fix this we check skb_dst() before skb_dst_force(), so we don't
drop skb packet with dst == NULL. This holds also for skb at the
PRE_ROUTING hook so we remove the second check.

Fixes: b60a7738 ("net: make skb_dst_force return true when dst is refcounted")
Signed-off-by: default avatarMarco Oliverio <marco.oliverio@tanaza.com>
Signed-off-by: default avatarRocco Folino <rocco.folino@tanaza.com>
Acked-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 5a2e6af8
...@@ -189,7 +189,7 @@ static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state, ...@@ -189,7 +189,7 @@ static int __nf_queue(struct sk_buff *skb, const struct nf_hook_state *state,
goto err; goto err;
} }
if (!skb_dst_force(skb) && state->hook != NF_INET_PRE_ROUTING) { if (skb_dst(skb) && !skb_dst_force(skb)) {
status = -ENETDOWN; status = -ENETDOWN;
goto err; goto err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment