Commit 0d152523 authored by Sanjana Sanikommu's avatar Sanjana Sanikommu Committed by Greg Kroah-Hartman

staging: media: imx: Replace list_entry with list_for_each_entry_safe

Challenge suggested by coccinelle.
Replace use of the combination of list_empty() and list_entry() with
list_for_each_entry_safe() to simplify the code.

Issue found using below Coccinelle script.

@@
expression E1;
identifier I1, I2;
type T;
iterator name list_for_each_entry_safe;
@@

T *I1;
+ T *tmp;
...
- while (list_empty(&E1) == 0)
+ list_for_each_entry_safe (I1, tmp, &E1, I2)
{
...when != T *I1;
- I1 = list_entry(E1.next, T, I2);
...
}
Signed-off-by: default avatarSanjana Sanikommu <sanjana99reddy99@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 643cd0a2
...@@ -556,6 +556,7 @@ static void capture_stop_streaming(struct vb2_queue *vq) ...@@ -556,6 +556,7 @@ static void capture_stop_streaming(struct vb2_queue *vq)
{ {
struct capture_priv *priv = vb2_get_drv_priv(vq); struct capture_priv *priv = vb2_get_drv_priv(vq);
struct imx_media_buffer *frame; struct imx_media_buffer *frame;
struct imx_media_buffer *tmp;
unsigned long flags; unsigned long flags;
int ret; int ret;
...@@ -570,9 +571,7 @@ static void capture_stop_streaming(struct vb2_queue *vq) ...@@ -570,9 +571,7 @@ static void capture_stop_streaming(struct vb2_queue *vq)
/* release all active buffers */ /* release all active buffers */
spin_lock_irqsave(&priv->q_lock, flags); spin_lock_irqsave(&priv->q_lock, flags);
while (!list_empty(&priv->ready_q)) { list_for_each_entry_safe(frame, tmp, &priv->ready_q, list) {
frame = list_entry(priv->ready_q.next,
struct imx_media_buffer, list);
list_del(&frame->list); list_del(&frame->list);
vb2_buffer_done(&frame->vbuf.vb2_buf, VB2_BUF_STATE_ERROR); vb2_buffer_done(&frame->vbuf.vb2_buf, VB2_BUF_STATE_ERROR);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment